Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATALOG-10610: Add custom_url field to POST v3 product 409 error #837

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BC-RSikora
Copy link
Contributor

@BC-RSikora BC-RSikora commented Feb 26, 2025

CATALOG-10610

What changed?

  • Add custom_url field to POST v3 product 409 error

Release notes draft

  • Endpoint POST v3/catalog/products now failed product creation when custom_url is not unique with 409 error code.

Anything else?

ping @bigcommerce/team-catalog

@BC-RSikora BC-RSikora marked this pull request as ready for review February 26, 2025 11:21
@BC-RSikora BC-RSikora requested a review from a team as a code owner February 26, 2025 11:21
@@ -597,7 +597,7 @@ paths:

'409':
description: |
`Product` was in conflict with another product. This is the result of duplicate unique values, such as name or SKU; a missing or invalid `category_id`, `brand_id`, or `tax_class id`; or a conflicting `bulk_pricing_rule`.
`Product` was in conflict with another product. This is the result of duplicate unique values, such as name or SKU; a missing or invalid `category_id`, `brand_id`, or `tax_class id`; or a conflicting `bulk_pricing_rule` or `custom_url`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Product` was in conflict with another product. This is the result of duplicate unique values, such as name or SKU; a missing or invalid `category_id`, `brand_id`, or `tax_class id`; or a conflicting `bulk_pricing_rule` or `custom_url`.
`Product` conflicted with another product. This is the result of duplicate unique values, such as name or SKU; a missing or invalid `category_id`, `brand_id`, or `tax_class id`; or a conflicting `bulk_pricing_rule` or `custom_url`.

Copy link
Collaborator

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion, feel free to take it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants