Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO TICKET [update] add Get all Bulk Pricing Rules endpoint #800

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

bc-traciporter
Copy link
Collaborator

NO TICKET

What changed?

Add get all bulk pricing rule endpoint

Release notes draft

Bug Fix
Add missing endpoint

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the need-SME-review A subject matter expert is needed to review. label Feb 4, 2025
@bc-traciporter bc-traciporter requested a review from a team as a code owner February 4, 2025 16:07
@bc-traciporter
Copy link
Collaborator Author

Hi @bc-romanliukshyn I removed the required fields from the response bodies. @megdesko said to remove the 404 error response for the bulk endpoint. I did that. Also I removed the include_fields query parameter. I am just wondering if I need to also remove the exclude_fields parameter.

@bc-traciporter
Copy link
Collaborator Author

@bc-romanliukshyn I added the include_fields query params

@bc-romanliukshyn
Copy link
Contributor

@bc-romanliukshyn I added the include_fields query params

thanks @bc-traciporter ! Not sure if you want to do this in scope of this PR, but there is the same issue with the include_fields param in the Get a Bulk Pricing Rule endpoint. Everything else looking good to me.

@bc-traciporter
Copy link
Collaborator Author

@bc-romanliukshyn I added the include_fields query params

thanks @bc-traciporter ! Not sure if you want to do this in scope of this PR, but there is the same issue with the include_fields param in the Get a Bulk Pricing Rule endpoint. Everything else looking good to me.

@bc-romanliukshyn This is a quick change. So the include fields should be the same as the Get all bulk pricing rule?

@bc-romanliukshyn
Copy link
Contributor

@bc-romanliukshyn I added the include_fields query params

thanks @bc-traciporter ! Not sure if you want to do this in scope of this PR, but there is the same issue with the include_fields param in the Get a Bulk Pricing Rule endpoint. Everything else looking good to me.

@bc-romanliukshyn This is a quick change. So the include fields should be the same as the Get all bulk pricing rule?

Yep, thank you. Approved

@bc-traciporter bc-traciporter merged commit 0930e99 into main Feb 6, 2025
3 checks passed
@bc-traciporter bc-traciporter deleted the bulk-pricing-rules branch February 6, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-SME-review A subject matter expert is needed to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants