Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-5007: [update] add redirect feature #798

Merged
merged 22 commits into from
Feb 27, 2025
Merged

Conversation

bc-traciporter
Copy link
Collaborator

@bc-traciporter bc-traciporter commented Feb 3, 2025

DEVDOCS-5007

What changed?

Added Redirect example under Get a Product.

Release notes draft

Redirect parameter on the route node.

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the need-SME-review A subject matter expert is needed to review. label Feb 3, 2025
@bc-traciporter bc-traciporter requested review from zvuki and bc-jz February 3, 2025 21:03
@bc-traciporter
Copy link
Collaborator Author

@bc-jz I updated the new routes markdown file. Can you take a look and ensure it is technically accurate? I am wondering if this new article is enough or do you think I still need to add something to the Routes section? Here is a preview of the text. You can see the graphQL examples in the PR. I added 3 examples (general query, query using IGNORE, and query using FOLLOW).

2025-02-12_15-41-13 Screenshot 2025-02-12 at 3 46 18 PM

bc-jz
bc-jz previously approved these changes Feb 21, 2025
Copy link

@bc-jz bc-jz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more comments above for some changes but with those in place I think this document will be ready!

bc-jz
bc-jz previously approved these changes Feb 25, 2025
Copy link

@bc-jz bc-jz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one change aside this is looking good! Nice work!

@zvuki zvuki requested a review from bookernath February 27, 2025 04:48
Copy link

@lukedsteiner lukedsteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read through, and tested each example in my personal store. Everything works as described, and how we speak to it in the related courses for BigDev.

@bc-traciporter bc-traciporter merged commit 845eeba into main Feb 27, 2025
3 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-5007-1 branch February 27, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-SME-review A subject matter expert is needed to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants