Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-5710 [add]: Metafields, add metafields batch endpoints #63

Merged
merged 45 commits into from
Feb 9, 2024

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Jan 29, 2024

DEVDOCS-5710

What changed?

  • Add endpoints of batch management of metafields

Release notes draft

  • The newly-released Metafield endpoints are now available to use. Now, you’ll be able to manage metafields in batches for all types of metafield, including those for product, product variants, and more.

Related PR

  • PR 281 for batch metafield endpoint for Locations API
  • PR 790 for redirects

@bc-andreadao bc-andreadao marked this pull request as ready for review January 30, 2024 16:00
@bc-andreadao bc-andreadao requested a review from bc-tayvs February 5, 2024 17:58
@bc-andreadao
Copy link
Collaborator Author

bc-andreadao commented Feb 8, 2024

@bc-tayvs Thanks for the review.

Based on your comments (and my testing), I changed the following for the responses:

  • 200 responses for POST, PUT, and DELETE methods all have an empty errors array
  • 422 responses for the POST, PUT, and DELETE methods all have an empty data array.

I also changed the type for the resource_ids to integer

For your comments on old code/endpoints: I created a new ticket (DEVDOCS-5770), so this PR can focus only on batch endpoints.

Let me know if there's anything else

@bc-tayvs
Copy link
Contributor

bc-tayvs commented Feb 8, 2024

@bc-andreadao

422 responses for the POST, PUT, and DELETE methods all have an empty data array.

422 is a partial success, so result could contain data as well as errors. Plz, make data field not empty for this case.
Thanks in advance.

bc-tayvs
bc-tayvs previously approved these changes Feb 8, 2024
@bc-andreadao
Copy link
Collaborator Author

@bc-tayvs Thanks, just changed the 422 responses so data field isn't empty

bc-tgomez
bc-tgomez previously approved these changes Feb 9, 2024
@bc-andreadao bc-andreadao merged commit e19b9ec into main Feb 9, 2024
4 checks passed
@bc-andreadao bc-andreadao deleted the DEVDOCS-5710-metafields-batch branch February 9, 2024 17:55
@bc-andreadao
Copy link
Collaborator Author

@bc-tayvs I created a new PR 141 to address your comments, if you can review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants