Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-6097:[update] add "Aftership" #565

Merged
merged 5 commits into from
Oct 23, 2024
Merged

DEVDOCS-6097:[update] add "Aftership" #565

merged 5 commits into from
Oct 23, 2024

Conversation

bc-traciporter
Copy link
Collaborator

@bc-traciporter bc-traciporter commented Oct 7, 2024

DEVDOCS-6097

What changed?

Added "Aftership"

Release notes draft

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Oct 7, 2024
@bc-traciporter bc-traciporter marked this pull request as ready for review October 7, 2024 15:52
@WillemHoman
Copy link
Contributor

@bc-traciporter This is the first time I have come across the Aftership terminology.
I didn't realise the /v2/orders/shipments called the shipping service like this 😮

@bigcommerce/team-shipping can you please review this PR for us.

@benpratt77
Copy link
Contributor

@bc-traciporter This is the first time I have come across the Aftership terminology. I didn't realise the /v2/orders/shipments called the shipping service like this 😮

@bigcommerce/team-shipping can you please review this PR for us.

Yeah Aftership is our backup tracking link for when a provider has not been setup in shipping provider or is not one of our natively integrated providers.
Also to note that if it is not in the list of External providers they will not get an aftership link either.

@bc-traciporter
Copy link
Collaborator Author

Thank you @benpratt77 for your feedback. I addressed your comments. Can you review them?

@bc-traciporter bc-traciporter merged commit 06d644a into main Oct 23, 2024
3 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-6097 branch October 23, 2024 20:21
@bc-traciporter
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants