-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVDOCS-6113: [update] matches aftership list #564
Conversation
@ben Can you also review this PR? |
You should check this against https://github.com/bigcommerce/shipping-service/blob/865c454d588a0e38740d800e07c6cbd6bb8fd6fe/src/Services/TrackingLink/ExternalCarriers.php#L4 That is our current list of providers that are supported from within the code base. If there are missing names in that file it is worth raising a ticket for us to update. |
might be the wrong ben 🤣 |
Sorry about that |
I don't have access to that link. I get a 404. |
One thing just observed is that Current master has Outside of that, I do regard continuing to update these docs manually as a bandaid solution. Would there be an option for something that is generated by engineering, directly referencing our actual source of truth that is active in production? Perhaps it is indeed the lesser of two evils to directly reference the Aftership list? My leaning is actually towards that, at this time, given repeated support concerns in this area. |
Closing ticket, instead we will point to the Aftership carrier list. See PR 603 |
DEVDOCS-6113
What changed?
Updated our tracking carrier list with list from aftership
Release notes draft
Anything else?
ping {names}