Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-6113: [update] matches aftership list #564

Closed
wants to merge 2 commits into from

Conversation

bc-traciporter
Copy link
Collaborator

@bc-traciporter bc-traciporter commented Oct 7, 2024

DEVDOCS-6113

What changed?

Updated our tracking carrier list with list from aftership

Release notes draft

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Oct 7, 2024
@bc-traciporter bc-traciporter marked this pull request as ready for review October 7, 2024 13:37
@bc-traciporter
Copy link
Collaborator Author

@ben Can you also review this PR?

@benpratt77
Copy link
Contributor

You should check this against https://github.com/bigcommerce/shipping-service/blob/865c454d588a0e38740d800e07c6cbd6bb8fd6fe/src/Services/TrackingLink/ExternalCarriers.php#L4 That is our current list of providers that are supported from within the code base.
This is what we use under the hood to figure out whether we reach out to aftership.

If there are missing names in that file it is worth raising a ticket for us to update.

@benpratt77
Copy link
Contributor

@ben Can you also review this PR?

might be the wrong ben 🤣

@bc-traciporter
Copy link
Collaborator Author

@ben Can you also review this PR?

might be the wrong ben 🤣

Sorry about that

@bc-traciporter
Copy link
Collaborator Author

You should check this against https://github.com/bigcommerce/shipping-service/blob/865c454d588a0e38740d800e07c6cbd6bb8fd6fe/src/Services/TrackingLink/ExternalCarriers.php#L4 That is our current list of providers that are supported from within the code base. This is what we use under the hood to figure out whether we reach out to aftership.

If there are missing names in that file it is worth raising a ticket for us to update.

benpratt77

I don't have access to that link. I get a 404.

@theromulans
Copy link
Contributor

theromulans commented Oct 21, 2024

One thing just observed is that directfreight-au-ref, for example, is not actually a tracking carrier string we support - suggesting perhaps there's a more modern variant we need here?

Current master has directfreight-au instead: https://github.com/bigcommerce/shipping-service/blob/28bf1e6b56de6d7e07d80571ae841df79077f82b/src/Services/TrackingLink/ExternalCarriers.php#L761C10-L761C18

Outside of that, I do regard continuing to update these docs manually as a bandaid solution. Would there be an option for something that is generated by engineering, directly referencing our actual source of truth that is active in production?

Perhaps it is indeed the lesser of two evils to directly reference the Aftership list? My leaning is actually towards that, at this time, given repeated support concerns in this area.

@bc-traciporter
Copy link
Collaborator Author

Closing ticket, instead we will point to the Aftership carrier list. See PR 603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants