B2B-1354: [update] add security details and cleanup #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becomevocal
reviewed
Oct 4, 2024
becomevocal
reviewed
Oct 4, 2024
becomevocal
reviewed
Oct 4, 2024
becomevocal
reviewed
Oct 4, 2024
becomevocal
approved these changes
Oct 8, 2024
bc-traciporter
added a commit
that referenced
this pull request
Oct 23, 2024
<!-- Ticket number or summary of work --> # [B2B-1354](https://bigcommercecloud.atlassian.net/browse/B2B-1354) ## What changed? <!-- Provide a bulleted list in the present tense --> ### Fix some issues Fix s2s endpoints issues in [google doc](https://docs.google.com/document/d/1maGQinFAxBQH8b3h0EGwzUZi9ikpf-mAgTWgVLqGo4I/edit?usp=sharing) * company a. Bulk Create Companies (request body has these additional read only fields (bcGroupName and companyStatus) **Create a new model for bulk company create (copy from orrigin), and remove 2 read only fields** * User a. Get a User (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** b. Get a User (meta is missing from the 404 error response) **Fix 404 response** c. Get a User (Should we document a 500 error response?) **Remove 500 response** d. Update a User (companyRoleId and companyRoleName are not in response body) **Add companyRoleName and companyRoleId in user response model** e. Delete a User (meta is missing from the 404 error response) **Fix 404 response** f. Delete a User (Should we document a 500 error response?) **Remove 500 response** g. Get Users (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** i. Bulk Create Company User (meta is missing from the 404 error response) **Fix 404 response** j. Get a User by Customer ID (companyRoleId and companyRoleName missing from response body) **Add companyRoleName and companyRoleId in user response model** k. Get a User by Customer ID (meta is missing from the 404 error response) **Fix 404 response** * Sales Staff a. Get a Sales Staff (assignedAt field is missing from the response body > assignedCompanies) **Add assignAt** * invoice payment a. Update a Offline Payment (422 error response is this correct? Data > currency) **Fix 422 response** ### Remove task section The task section has been removed in PR [535](#535), but re-created in PR [562](#562). May be conflicts between PR. As this section has already been removed in the original Stoplight, it should be removed again. ## Release notes draft <!-- Provide an entry for the release notes using simple, conversational language. Don't be too technical. Explain how the change will benefit the merchant and link to the feature. Examples: * The newly-released [X feature] is now available to use. Now, you’ll be able to [perform Y action]. * We're happy to announce [X feature], which can help you [perform Y action]. * [X feature] helps you to create [Y response] using the [Z query parameter]. Now, you can deliver [ex, localized shopping experiences for your customers]. * Fixed a bug in the [X endpoint]. Now the [Y field] will appear when you click [Z option]. --> n/a [B2B-1354]: https://bigcommercecloud.atlassian.net/browse/B2B-1354?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Traci Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B2B-1354
What changed?
Added security information and clean up
Release notes draft
Anything else?
ping {names}