-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Filter hook for Image Size on Cart Items #446
base: master
Are you sure you want to change the base?
Conversation
I am along with @bc-erich triaging the queues for PRs and it looks like this one could do with moving on a little. In order to do that I would love to consider if this is something to get into the next release and if so can we get a review. Looping in @chanceaclark for input. |
@karmatosed I'm going to be frank here and I'm not sure how filters hooks work in WP. I'd love a little Proof of Life here that it works, otherwise if you think it looks good I'll trust you. |
That's absolutely no issue. @M4hd1BD I realise this was a little while ago, would it be possible to get the following from you to confirm this as we seem to be missing some details to your PR.
Aside from that, we do need testing on this to ensure it both works and is still valid since a little time has passed. |
Hi @karmatosed, I don't remember if I tested it initially when I did the PR, I must've. Anyway, took me a while to set up the environment but I have tested it again.
2024-09-19_23-23-56.mp4Let me know if you guys need anything else from me. |
What?
Add a filter hook, namely
bigcommerce/template/cart_items_image/size
, for the IMAGE_SIZE option on the Cart_Items template.Tickets / Documentation
N/A
Screenshots (if appropriate)
N/A