B2B-2150 fix types and simplify getFilterMoreList within ShippingLists #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last in ShippingLists
…o hooks in ShippingLists
…tStatus in ShippingLists
…tus in ShippingLists
…atus in ShippingLists
…istStatus in ShippingLists
…Status in ShippingLists
…t in ShippingLists
…ithin ShoppingLists
leeBigCommerce
force-pushed
the
B2B-2150-d
branch
from
4b9a6c8 to
5187a95
Compare
icatalina
approved these changes
Feb 19, 2025
| @@ -54,6 +54,7 @@ function ShoppingLists() { | |||
| const [deleteOpen, setDeleteOpen] = useState<boolean>(false); | |||
| const [deleteItem, setDeleteItem] = useState<null | ShoppingListsItemsProps>(null); | |||
| const [filterMoreInfo, setFilterMoreInfo] = useState<Array<any>>([]); | |||
| const getFilterMoreList = useGetFilterMoreList(); | |||
There was a problem hiding this comment.
🤔 do we want to push this to useData as well?
There was a problem hiding this comment.
right now it's full of building blocks for visual concerns, rather than data we'd expect from I/O:
{
name: 'createdBy',
required: false,
default: '',
fieldType: 'dropdown',
options: newCreatedByUsers,
replaceOptions: { label: 'createdBy', value: 'createdBy' },
xs: 12,
variant: 'filled',
size: 'small',
label: b3Lang('global.shoppingLists.filter.createdBy'),
}my hope is that we can instead move these values out and closer to JSX that requires them, eventually making this hook redundant 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: B2B-2150
N.B. - this might be easy enough to read as one change, rather than 1 commit at a time
What/Why?
getFilterMoreListcreated a list of filters that was transformed within the viewgetFilterMoreList(now the return function of a hook)B3Filterto workout if or notgetFilterMoreList's interface can be further simplifiedRollout/Rollback
Testing