Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DATA-11968 Update Generative model to latest version #50

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

bc-rmalyavc
Copy link
Contributor

@bc-rmalyavc bc-rmalyavc commented May 27, 2024

What & Why? DATA-11968

  • Switch to @google-cloud/vertexai sdk in order to use latest models
  • Use the latest generative model gemini-1.5-pro-001
  • Update related env variables and authentication sequence as per new sdk requirements
  • Update README to reflect changes in authentication process

Testing / Proof

  • Manually in dev mode.
    • Created a service account as per step 8 in README
    • Created a draft app in BigCommerce dev portal and directed it the app run locally via ngrok (see README)
    • Verified that the the app is working and is able to generate descriptions for the product.
  • Manually on preview app (In progress)
    • Deployed the changes to Preview environment on Vercel
    • Created a service account as per step 8 in README
    • Created a new env variable GOOGLE_SERVICE_ACCOUNT_JSON_BASE64 in Preview env and pasted the base64 encoded account details as a value for it.
    • Created another draft app and directed it to the app deployed in Preview env.
    • Installed the draft app to a sandbox store and verified that it is working and is able to generate description for the product

image

Some other examples of the old vs new model

The old model fails to generate the description in humorous style as requeted
Screenshot 2024-08-01 at 17 40 17

The new model successfully returns a humorous description
Screenshot 2024-08-01 at 17 39 28

@bigcommerce/team-data

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-app-foundation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 6:15pm

@bc-rmalyavc bc-rmalyavc changed the title feat: DATA-11968 Update Model feat: DATA-11968 Update Generative model to latest version May 29, 2024
@bc-rmalyavc bc-rmalyavc marked this pull request as ready for review May 29, 2024 12:24
@bc-rmalyavc bc-rmalyavc requested a review from a team as a code owner May 29, 2024 12:24
Copy link
Collaborator

@solofeed solofeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@solofeed
Copy link
Collaborator

Let's not merge until we get a service account for a vertex AI

I will comment on it here

Copy link

@bc-prestonhuth bc-prestonhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs clear evidence of what was tested and how. It also needs a clear deployment plan. Specifically, what steps need to be taken to configure the service account properly? It would help to point out the documentation that was linked in the README from the PR description so it is clear what steps are being followed.

Please update the PR template as well to match here.

Copy link

@bc-prestonhuth bc-prestonhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not seeing anything convincing me that this change is well tested and safe to deploy OR that the intended change was achieved. Is there a way to prove that we are now hitting the latest version of the model?

@bc-rmalyavc
Copy link
Contributor Author

bc-rmalyavc commented Aug 1, 2024

I'm still not seeing anything convincing me that this change is well tested and safe to deploy OR that the intended change was achieved. Is there a way to prove that we are now hitting the latest version of the model?

@bc-prestonhuth,
I have updated the testing section in the PR description. Listed all steps we performed to make sure that the change is safe to deploy. Also updated the PR template as you requested.

Is there a way to prove that we are now hitting the latest version of the model?
We were able to see the endpoint hit in the console in Vercel. Perhaps, @solofeed can share some screenshots if you feel like you need to see them

OR that the intended change was achieved
The intended change was to improve the quality of descriptions generated by switching to the latest model. I'm not sure we can really prove it. Though, as per the screenshot I posted you can see that it started adding emoji) I believe it didn't previously

Copy link

@bc-prestonhuth bc-prestonhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated test information and screenshot now provides confidence that this change has been tested well.

@bc-rmalyavc bc-rmalyavc merged commit 721c214 into main Aug 2, 2024
3 checks passed
@bc-rmalyavc bc-rmalyavc deleted the DATA-11968 branch August 2, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants