-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DATA-11968 Update Generative model to latest version #50
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's not merge until we get a service account for a vertex AI I will comment on it here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs clear evidence of what was tested and how. It also needs a clear deployment plan. Specifically, what steps need to be taken to configure the service account properly? It would help to point out the documentation that was linked in the README from the PR description so it is clear what steps are being followed.
Please update the PR template as well to match here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not seeing anything convincing me that this change is well tested and safe to deploy OR that the intended change was achieved. Is there a way to prove that we are now hitting the latest version of the model?
@bc-prestonhuth,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated test information and screenshot now provides confidence that this change has been tested well.
What & Why? DATA-11968
@google-cloud/vertexai
sdk in order to use latest modelsgemini-1.5-pro-001
README
to reflect changes in authentication processTesting / Proof
README
BigCommerce
dev portal and directed it the app run locally via ngrok (see README)README
GOOGLE_SERVICE_ACCOUNT_JSON_BASE64
in Preview env and pasted the base64 encoded account details as a value for it.Preview
env.Some other examples of the old vs new model
The old model fails to generate the description in humorous style as requeted

The new model successfully returns a humorous description

@bigcommerce/team-data