-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version number consistency check for conda recipe #189
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request introduces a version consistency check in the Conda build GitHub Actions workflow and updates the package version from 0.0.30 to 0.0.31. The new workflow step ensures that the version numbers in the package and Conda recipe match, adding an extra validation layer during the build process. The build command has also been slightly modified by removing the Changes
Sequence DiagramsequenceDiagram
participant Workflow as GitHub Actions
participant Package as sdrf-pipelines
participant Recipe as meta.yaml
participant Build as Conda Build
Workflow->>Package: Retrieve package version
Workflow->>Recipe: Read recipe version
Workflow->>Workflow: Compare versions
alt Versions Match
Workflow-->>Build: Proceed with build
else Versions Mismatch
Workflow-->>Workflow: Raise ValueError
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/conda-build.yml (1)
39-40
: Use relative paths in error messages.The error message references specific file paths that may not match the actual repository structure. Use relative paths for better portability.
- f"\nVersion in ./sdrf_pipelines/__init__.py: {package_version}" - f"\nVersion in ./recipe/meta.yaml: {recipe_version}" + f"\nPackage version: {package_version}" + f"\nRecipe version: {recipe_version}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/conda-build.yml
(2 hunks)recipe/meta.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- recipe/meta.yaml
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
🔇 Additional comments (1)
.github/workflows/conda-build.yml (1)
59-59
: Verify if package upload to Anaconda is intended.The
--no-anaconda-upload
flag has been removed from the conda build command. This change could potentially lead to package uploads to Anaconda. Please confirm if this is intentional.
User description
This PR adds a version number consistency check for the conda recipe.
It is implemented so the conda package build fails fast if the version number doesn't match.
PR Type
Enhancement, Tests
Description
Added a version number consistency check in the CI workflow.
Updated the version number in the conda recipe to
0.0.31
.Ensured the conda build process fails fast on version mismatch.
Changes walkthrough 📝
conda-build.yml
Add version consistency check to CI workflow
.github/workflows/conda-build.yml
conda recipe.
--no-anaconda-upload
flag.
meta.yaml
Update version number in conda recipe
recipe/meta.yaml
0.0.30
to0.0.31
.Summary by CodeRabbit