Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update of ibaqpy #45

Merged
merged 15 commits into from
Apr 14, 2024
Merged

Major update of ibaqpy #45

merged 15 commits into from
Apr 14, 2024

Conversation

WangHong007
Copy link
Contributor

No description provided.

@WangHong007
Copy link
Contributor Author

WangHong007 commented Mar 15, 2024

#43 #44 Bugs fixed.
@ypriverol I think we've got back to the commit we want, but let @zprobot test and update it first and then merge the PR. What do you think?

@WangHong007
Copy link
Contributor Author

@ypriverol After testing by @zprobot, this PR could be merged. Please check all changes again.

@ypriverol
Copy link
Member

@WangHong007 @zprobot We have two PR now, #45 #46 Please coordinate which one is the last one with the refactoring.

@ypriverol
Copy link
Member

Agreed. Remember always to update the README.

@WangHong007 WangHong007 changed the title Don't merge, testing for the rollback... Major update of ibaqpy Apr 13, 2024
@WangHong007
Copy link
Contributor Author

@ypriverol PR is ready, please take a look. #46 should be closed.

@ypriverol ypriverol self-requested a review April 13, 2024 19:41
@ypriverol ypriverol merged commit 7949451 into bigbio:master Apr 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants