-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create validation context classes from schema.meta.context #2
Draft
effigies
wants to merge
21
commits into
bids-standard:main
Choose a base branch
from
effigies:enh/context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
===========================================
- Coverage 93.19% 74.87% -18.33%
===========================================
Files 3 7 +4
Lines 191 386 +195
Branches 55 101 +46
===========================================
+ Hits 178 289 +111
- Misses 5 83 +78
- Partials 8 14 +6 ☔ View full report in Codecov by Sentry. |
effigies
commented
Jul 11, 2024
effigies
force-pushed
the
enh/context
branch
2 times, most recently
from
August 15, 2024 15:08
9bd5cec
to
684e753
Compare
effigies
commented
Nov 11, 2024
… be inspected for history
effigies
force-pushed
the
enh/context
branch
from
November 11, 2024 18:22
3c9267c
to
bfb3e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to think about how to write a Python validator that builds from the schema, rather than replicating the schema. Here's some bits that make it easy to generate structured classes for the validation context (
schema.meta.context.context
) based on either the bidsschematools schema or a schema loaded from JSON.So far I have attrs classes that populate the context. It's unclear if it's worth doing something similar with the whole schema, which would be much more involved (patternProperties, additionalProperties, and the like).