-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --force mode for metadata.yml file #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Remi-Gau
reviewed
Jul 9, 2024
Remi-Gau
reviewed
Jul 9, 2024
Remi-Gau
reviewed
Jul 9, 2024
Remi-Gau
reviewed
Jul 9, 2024
Comment on lines
50
to
53
"""Load the metadata.yml file with the additional metadata.\n | ||
This file must contain at least the additional REQUIRED metadata | ||
You can find a template in the eye2bids GitHub.\n | ||
This file must contain at least the additional REQUIRED metadata\n | ||
in the format specified in the BIDS specification.\n""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update message to let users know how to avoid this warning
Remi-Gau
reviewed
Jul 9, 2024
Remi-Gau
reviewed
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification: so far it was ok not to pass a metadata.yml file. However, this file contains required metadata. Now the program stops if no metadata.yml file was passed and gives information on why the program stopped and how to fix that. Additionally, now it hase a
--force
flag where Users can still convert their edfs without passing a metadata.yml file. The user is then informed that the resulting dataset is invalid to BIDS.Closes #83