Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change output format for tsv to tsv.gz to make compression work #53

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

julia-pfarr
Copy link
Member

as discussed in our meeting in december and according to issue #47

@julia-pfarr julia-pfarr requested a review from Remi-Gau January 12, 2024 11:00
@julia-pfarr
Copy link
Member Author

The tests give me the error "not a gzipped file". When I run the converter my output is a tsv.gz file and it seems properly zipped. Do you know if the issue is within the converter, i.e. it seems zipped but isn't correctly zipped, or is it in the test that pd.read_csv is not working on zipped files?

@Remi-Gau
Copy link
Contributor

not sure why the gzip compression did not work with pandas directly so went on with calling gzip directly.

@Remi-Gau Remi-Gau merged commit 7854b5c into main Feb 22, 2024
6 of 7 checks passed
@Remi-Gau Remi-Gau deleted the julia branch June 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants