Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visualisation for paper #1

Merged
merged 7 commits into from
Oct 10, 2022
Merged

Add visualisation for paper #1

merged 7 commits into from
Oct 10, 2022

Conversation

bartvanerp
Copy link
Member

I will add the figures next week. @JimBeckers the pnr column in the datasets, do these resemble the SPR metric? Also could you check the comparison plots, SPR looks very weird.

@JimBeckers
Copy link
Contributor

  • The pnr column is indeed for SPR, this was a typo on my part and can be changed. @bartvanerp, let me know if you can change it or I need to do it.
  • The weird behaviour of SPR is consistent with the other datasets and is most likely due to it being a bad pruning metric. I also ran the experiments with more samples, but this didn't affect the results.

@bartvanerp
Copy link
Member Author

Oke thanks @JimBeckers, I will change this and merge

@bartvanerp bartvanerp merged commit 76edaf6 into main Oct 10, 2022
@bartvanerp bartvanerp deleted the paper-visualisation branch October 10, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBeckers JimBeckers Awaiting requested review from JimBeckers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartvanerp @JimBeckers