Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect correlation heatmap axes labels #114

Closed
wants to merge 48 commits into from

Conversation

strixy16
Copy link
Collaborator

@strixy16 strixy16 commented Jan 30, 2025

Vertical and horizontal feature labels were swapped on the x and y axes for the correlation heatmaps in plotCrossCorrHeatmap

Summary by CodeRabbit

  • New Features

    • Added image processing module with advanced cropping and bounding box functionalities
    • Introduced methods for calculating image centroids and cropping images using various strategies
  • Documentation

    • Added module-level docstrings for image processing components
    • Defined clear public interfaces for image manipulation functions
  • Tests

    • Comprehensive test suite added for image cropping and processing functions
    • Implemented fixtures and test cases for different image manipulation scenarios

strixy16 and others added 30 commits January 17, 2025 15:53
…for quick checking dimension match between image and centroid/mask/dimensions/etc.
…to centroid, and mask update in crop with pyradiomics
jjjermiah and others added 18 commits January 21, 2025 14:07
@strixy16 strixy16 closed this Jan 30, 2025
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces comprehensive image processing capabilities for medical imaging, focusing on cropping and manipulating 3D images. The changes span multiple files in the readii package, adding new modules and functions for image cropping, bounding box calculations, and centroid identification. Additionally, there's a minor modification to the plotCrossCorrHeatmap function's axis labeling. The implementation includes robust type hinting, detailed docstrings, and accompanying unit tests to ensure the reliability of the new image processing functionalities.

Changes

File Change Summary
src/readii/analyze/plot_correlation.py Updated xlabel and ylabel parameters in plotCrossCorrHeatmap function
src/readii/process/images/__init__.py Added module-level docstring and defined __all__ list for image processing functions
src/readii/process/images/crop.py Added multiple functions for image cropping, bounding box calculation, and centroid finding
src/readii/process/images/utils/bounding_box.py Introduced new classes: Point3D, Size3D, Coordinate, and Centroid for 3D spatial representations
tests/process/images/test_crop.py Added comprehensive unit tests for new image processing functions

Sequence Diagram

sequenceDiagram
    participant Image
    participant Mask
    participant CropFunction
    participant ProcessedImage

    Image->>Mask: Provide input image and mask
    Mask->>CropFunction: Select cropping method
    CropFunction->>CropFunction: Calculate bounding box/centroid
    CropFunction->>ProcessedImage: Apply cropping
    ProcessedImage-->>Image: Return cropped image
Loading

Possibly related PRs

Suggested reviewers

  • jjjermiah

Poem

🐰 Hop, hop, through pixels bright,
Cropping images with rabbit might!
Bounding boxes dance and sway,
Centroids marking the scientific way
Code hops forward, images take flight! 🔬


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3df3a55 and 67df81b.

📒 Files selected for processing (5)
  • src/readii/analyze/plot_correlation.py (1 hunks)
  • src/readii/process/images/__init__.py (1 hunks)
  • src/readii/process/images/crop.py (1 hunks)
  • src/readii/process/images/utils/bounding_box.py (1 hunks)
  • tests/process/images/test_crop.py (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@strixy16 strixy16 deleted the katys/fix/correlation_heatmap_axes branch January 30, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants