Skip to content

Commit

Permalink
Set install_requires in setup.py.
Browse files Browse the repository at this point in the history
Updates setup.py to set install_requires using parse_requirements from
openstack-common.  This allows DevStack to install nova requirements, as
currently they are not handled.

Also relaxes the version requirement for lxml to >=2.3,<3.  This allows
DevStack to install nova requirements without needing to install lxml
over the installed python-xml system package, currently 2.3.2.

Change-Id: Iccebf9604ba5c6fcacb4c5fa5004f9fcb08944f3
  • Loading branch information
Andrew Laski committed Sep 7, 2012
1 parent 37cc45b commit ccc0bfb
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions nova/tests/test_libvirt_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ def test_config_network(self):
self.assertXmlEqual(xml, """
<disk type="network" device="disk">
<driver name="qemu" type="qcow2"/>
<source protocol="iscsi" name="foo.bar.com"/>
<source name="foo.bar.com" protocol="iscsi"/>
<target bus="ide" dev="/dev/hda"/>
</disk>""")

Expand All @@ -387,7 +387,7 @@ def test_config_network_auth(self):
self.assertXmlEqual(xml, """
<disk type="network" device="disk">
<driver name="qemu" type="raw"/>
<source protocol="rbd" name="pool/image"/>
<source name="pool/image" protocol="rbd"/>
<auth username="foo">
<secret type="ceph"
uuid="b38a3f43-4be2-4046-897f-b67c2f5e0147"/>
Expand Down Expand Up @@ -530,7 +530,7 @@ def test_config_8021Qbh(self):
<interface type="direct">
<mac address="DE:AD:BE:EF:CA:FE"/>
<model type="virtio"/>
<source mode="private" dev="eth0"/>
<source dev="eth0" mode="private"/>
<virtualport type="802.1Qbh"/>
</interface>""")

Expand Down
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from nova.openstack.common import setup as common_setup
from nova import version

requires = common_setup.parse_requirements()

setuptools.setup(name='nova',
version=version.canonical_version_string(),
Expand All @@ -32,6 +33,7 @@
url='http://www.openstack.org/',
cmdclass=common_setup.get_cmdclass(),
packages=setuptools.find_packages(exclude=['bin', 'smoketests']),
install_requires=requires,
include_package_data=True,
test_suite='nose.collector',
setup_requires=['setuptools_git>=0.4'],
Expand Down
2 changes: 1 addition & 1 deletion tools/pip-requires
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ anyjson==0.2.4
boto==2.1.1
eventlet>=0.9.17
kombu==1.0.4
lxml==2.3
lxml>=2.3,<3
routes==1.12.3
WebOb==1.0.8
greenlet>=0.3.1
Expand Down

0 comments on commit ccc0bfb

Please sign in to comment.