Merge "Optimizes flavor_access to not make a db request"

bhagemeier · Sep 5, 2012 · c69982e · c69982e
2 parents 07e0b77 + 559cb7a
commit c69982e
Showing 1 changed file with 6 additions and 18 deletions.
diff --git a/nova/api/openstack/compute/contrib/flavor_access.py b/nova/api/openstack/compute/contrib/flavor_access.py
@@ -139,14 +139,9 @@ def show(self, req, resp_obj, id):
         if authorize(context):
             # Attach our slave template to the response object
             resp_obj.attach(xml=FlavorextradatumTemplate())
+            db_flavor = req.get_db_flavor(id)
 
-            try:
-                flavor_ref = instance_types.get_instance_type_by_flavor_id(id)
-            except exception.FlavorNotFound:
-                explanation = _("Flavor not found.")
-                raise webob.exc.HTTPNotFound(explanation=explanation)
-
-            self._extend_flavor(resp_obj.obj['flavor'], flavor_ref)
+            self._extend_flavor(resp_obj.obj['flavor'], db_flavor)
 
     @wsgi.extends
     def detail(self, req, resp_obj):
@@ -156,11 +151,9 @@ def detail(self, req, resp_obj):
             resp_obj.attach(xml=FlavorextradataTemplate())
 
             flavors = list(resp_obj.obj['flavors'])
-            flavor_refs = self._get_flavor_refs(context)
-
             for flavor_rval in flavors:
-                flavor_ref = flavor_refs[flavor_rval['id']]
-                self._extend_flavor(flavor_rval, flavor_ref)
+                db_flavor = req.get_db_flavor(flavor_rval['id'])
+                self._extend_flavor(flavor_rval, db_flavor)
 
     @wsgi.extends(action='create')
     def create(self, req, body, resp_obj):
@@ -169,14 +162,9 @@ def create(self, req, body, resp_obj):
             # Attach our slave template to the response object
             resp_obj.attach(xml=FlavorextradatumTemplate())
 
-            try:
-                fid = resp_obj.obj['flavor']['id']
-                flavor_ref = instance_types.get_instance_type_by_flavor_id(fid)
-            except exception.FlavorNotFound:
-                explanation = _("Flavor not found.")
-                raise webob.exc.HTTPNotFound(explanation=explanation)
+            db_flavor = req.get_db_flavor(resp_obj.obj['flavor']['id'])
 
-            self._extend_flavor(resp_obj.obj['flavor'], flavor_ref)
+            self._extend_flavor(resp_obj.obj['flavor'], db_flavor)
 
     @wsgi.serializers(xml=FlavorAccessTemplate)
     @wsgi.action("addTenantAccess")