Merge "Make size optional when creating a volume from a snapshot."

bhagemeier · Sep 10, 2012 · 14e0b7d · 14e0b7d
2 parents d938aed + 210dc28
commit 14e0b7d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/nova/api/openstack/compute/contrib/volumes.py b/nova/api/openstack/compute/contrib/volumes.py
@@ -224,8 +224,6 @@ def create(self, req, body):
             raise exc.HTTPUnprocessableEntity()
 
         vol = body['volume']
-        size = vol['size']
-        LOG.audit(_("Create volume of %s GB"), size, context=context)
 
         vol_type = vol.get('volume_type', None)
         if vol_type:
@@ -244,6 +242,12 @@ def create(self, req, body):
         else:
             snapshot = None
 
+        size = vol.get('size', None)
+        if size is None and snapshot is not None:
+            size = snapshot['volume_size']
+
+        LOG.audit(_("Create volume of %s GB"), size, context=context)
+
         availability_zone = vol.get('availability_zone', None)
 
         new_volume = self.volume_api.create(context,

diff --git a/nova/api/openstack/volume/volumes.py b/nova/api/openstack/volume/volumes.py
@@ -219,10 +219,6 @@ def create(self, req, body):
 
         volume = body['volume']
 
-        size = volume['size']
-
-        LOG.audit(_("Create volume of %s GB"), size, context=context)
-
         kwargs = {}
 
         req_volume_type = volume.get('volume_type', None)
@@ -242,6 +238,12 @@ def create(self, req, body):
         else:
             kwargs['snapshot'] = None
 
+        size = volume.get('size', None)
+        if size is None and kwargs['snapshot'] is not None:
+            size = kwargs['snapshot']['volume_size']
+
+        LOG.audit(_("Create volume of %s GB"), size, context=context)
+
         kwargs['availability_zone'] = volume.get('availability_zone', None)
 
         new_volume = self.volume_api.create(context,