Improve FLUX tool for output label and prompt display #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Nov 27, 2024
| @@ -39,7 +39,7 @@ python3 '$__tool_directory__/flux.py' | |||
| </conditional> | |||
| </inputs> | |||
| <outputs> | |||
| <data name="output" format="png" label="${tool.name} on ${on_string}" from_work_dir="./output.png"/> | |||
| <data name="output" format="png" label="${tool.name} on ${on_string if $input_type_selector=='file' else 'text prompt'}" from_work_dir="./output.png"/> | |||
There was a problem hiding this comment.
if that a good idea? We don't know how large the prompt will be
There was a problem hiding this comment.
It doesn't add the prompt it self, it just announces that it is a text prompt.
Before it was empty, if it was not a file.
There was a problem hiding this comment.
Or should it be a short text about the prompt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the output label based on the input type and include the prompt in the console output when using FLUX tool.