-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webassembly version #63
base: master
Are you sure you want to change the base?
Conversation
build/build_lgpl.sh
Outdated
@@ -39,11 +39,11 @@ rm *.bc | |||
cp lib/libz.a libz.bc | |||
cp ../ffmpeg/ffmpeg ffmpeg.bc | |||
|
|||
emcc -s OUTLINING_LIMIT=100000 -v -s TOTAL_MEMORY=33554432 -O2 ffmpeg.bc -o ../ffmpeg.js --pre-js ../ffmpeg_pre.js --post-js ../ffmpeg_post.js | |||
emcc -v -s TOTAL_MEMORY=33554432 -Os ffmpeg.bc -o ../ffmpeg.js --pre-js ../ffmpeg_pre.js --post-js ../ffmpeg_post.js -s WASM=1 -s "BINARYEN_METHOD='native-wasm'" -s ALLOW_MEMORY_GROWTH=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, that's a simple change to get wasm working
Do you have any ideas on how to improve these things? |
@bgrins @jonasof I played around with this PR recently, and I've solved the multiple .wasm download issue. The key here is to download and compile the WASM file outside of Change the
Then update
Finally, in the worker that calls
I will open a PR against this PR later tonight. |
any news? |
Hello, what's the status of this PR? Is it production ready software? Should it branch into it's own project? Thanks. |
I'm also wondering about the status of this. Would really love to use it. |
Resolve #43.
Depends pull request #55, currently open.
I suggest merging this at new branch like "webassembly". Some things in demo are not working well like loading message and there is too repeating .wasm parses.
Demo available at: https://jonasof.github.io/videoconverter.js-wasm-demo/