Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to RTR version 1 - RFC 8210; the ASPA work still is in flux hindering users #124

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

job
Copy link
Member

@job job commented Aug 6, 2024

Switch to RTR version 1 by default (RFC 8210); the ASPA work still is in flux hindering users.

We can revisit this choice in a few months

@job
Copy link
Member Author

job commented Aug 6, 2024

@cjeker what do you think?

@ties
Copy link
Collaborator

ties commented Aug 6, 2024 via email

@job
Copy link
Member Author

job commented Aug 6, 2024

@ties In environments where mixes of older and newer versions are used (OpenBGPD, Routinator, StayRTR), we've now received a number of reports about confusion and things not working as people expect them to work.

Since the ASPA PDU format is not stable: there still are outstanding issues, the authors appear to be very busy with other non-ASPA things, I think we need to cut our losses and let the users come first.

It's easy to change this in the future once ASPA RTR is more fleshed out.

Related and ignored: https://mailarchive.ietf.org/arch/msg/sidrops/F5DJRF9Mkqef1pONEOcSqahVWok/

@ties
Copy link
Collaborator

ties commented Aug 6, 2024 via email

@job
Copy link
Member Author

job commented Aug 6, 2024

It feels like we burned a version number by having a potential format change after the first release of the support. In a protocol with weak version negotiation. Yikes.

Yes. Could’ve been avoided if the development cycle was slightly faster than changing spec once every 14 months

@cjeker
Copy link
Contributor

cjeker commented Aug 6, 2024

@cjeker what do you think?

Why Version 0 instead of 1 (RFC8210)? RFC 8210 includes a different 'End of Data' PDU which includes the timing params.
I think StayRTR should default to 1 even though nobody needs the BGPSec keys.

@job
Copy link
Member Author

job commented Aug 6, 2024

@cjeker what do you think?

Why Version 0 instead of 1 (RFC8210)? RFC 8210 includes a different 'End of Data' PDU which includes the timing params. I think StayRTR should default to 1 even though nobody needs the BGPSec keys.

You make a good point, thanks for the clue bat

job added 2 commits August 6, 2024 21:10
As @cjeker suggested, version 1 brings other benefits aside from BGPsec
Also fix description
@cjeker
Copy link
Contributor

cjeker commented Aug 6, 2024

Looks good to me.

@job job merged commit cef0a53 into master Aug 6, 2024
3 checks passed
@job job changed the title Switch to RTR version 0 - RFC 6810; the ASPA work still is in flux hindering users Switch back to RTR version 1 - RFC 8210; the ASPA work still is in flux hindering users Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants