The default message detection func is now statically set to avoid hav…

…ing to do it all over the place
bfcamara · Sep 26, 2011 · ce986eb · ce986eb
1 parent 700f598
commit ce986eb
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 17 deletions.
diff --git a/src/config/NServiceBus.Config/Configure.cs b/src/config/NServiceBus.Config/Configure.cs
@@ -178,9 +178,6 @@ public static Configure With(IEnumerable<Type> typesToScan)
 
             TypesToScan = typesToScan;
 
-            ExtensionMethods.IsMessageTypeAction =
-                    t => typeof(IMessage).IsAssignableFrom(t) && typeof(IMessage) != t;
-
             return instance;
         }
 

diff --git a/src/core/NServiceBus/ExtensionMethods.cs b/src/core/NServiceBus/ExtensionMethods.cs
@@ -238,7 +238,7 @@ public static void CopyHeaderFromRequest(this object msg, string key)
         /// <summary>
         /// The function used to determine whether a type is a message type.
         /// </summary>
-        public static Func<Type, bool> IsMessageTypeAction { get; set; }
+        public static Func<Type, bool> IsMessageTypeAction = t => typeof(IMessage).IsAssignableFrom(t) && typeof(IMessage) != t;
 
 
         /// <summary>

diff --git a/src/impl/Serializers/NServiceBus.Serializers.XML.Test/SerializerTests.cs b/src/impl/Serializers/NServiceBus.Serializers.XML.Test/SerializerTests.cs
@@ -20,12 +20,6 @@ public class SerializerTests
         private int number = 1;
         private int numberOfIterations = 100;
 
-        [SetUp]
-        public void Setup()
-        {
-            NServiceBus.ExtensionMethods.IsMessageTypeAction = t => typeof(IMessage).IsAssignableFrom(t) && t != typeof(IMessage);
-        }
-
         [Test]
         public void Generic_properties_should_be_supported()
         {

diff --git a/src/impl/Serializers/NServiceBus.Serializers.XML.Test/SerializingArrayTests.cs b/src/impl/Serializers/NServiceBus.Serializers.XML.Test/SerializingArrayTests.cs
@@ -24,11 +24,6 @@ public MessageWithArray(Guid sagaId, int[] someInts)
     [TestFixture]
     public class SerializingArrayTests
     {
-        [SetUp]
-        public void Setup()
-        {
-            NServiceBus.ExtensionMethods.IsMessageTypeAction = t => typeof (IMessage).IsAssignableFrom(t) && t != typeof(IMessage);
-        }
 
         [Test]
         public void CanDeserializeXmlWithWhitespace()

diff --git a/src/testing/NServiceBus.Testing.Tests/TestHandlerFixture.cs b/src/testing/NServiceBus.Testing.Tests/TestHandlerFixture.cs
@@ -10,7 +10,6 @@ public class TestHandlerFixture
         public void TestFixtureSetUp()
         {
             Test.Initialize(typeof(IMessage).Assembly, typeof(TestHandlerFixture).Assembly);
-            ExtensionMethods.IsMessageTypeAction = t => typeof (IMessage).IsAssignableFrom(t) && t != typeof (IMessage);
         }
 
         [Test]

diff --git a/src/unicast/NServiceBus.Unicast.Tests/Contexts/using_the_unicastbus.cs b/src/unicast/NServiceBus.Unicast.Tests/Contexts/using_the_unicastbus.cs
@@ -37,7 +37,6 @@ public void SetUp()
             {
             }
 
-            ExtensionMethods.IsMessageTypeAction = t => typeof(IMessage).IsAssignableFrom(t) && t != typeof(IMessage);
             ExtensionMethods.GetStaticOutgoingHeadersAction = () => MessageHeaderManager.staticHeaders;
             gatewayAddress = masterNodeAddress.SubScope("gateway");
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,7 +10,6 @@ public class TestHandlerFixture @@
             public void TestFixtureSetUp()
             {
                 Test.Initialize(typeof(IMessage).Assembly, typeof(TestHandlerFixture).Assembly);
-                ExtensionMethods.IsMessageTypeAction = t => typeof (IMessage).IsAssignableFrom(t) && t != typeof (IMessage);
             }
             [Test]
@@ Expand Down @@