Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup publish process #17728

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Cleanup publish process #17728

merged 3 commits into from
Feb 9, 2025

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 7, 2025

Objective

  • publish script copy the license files to all subcrates, meaning that all publish are dirty. this breaks git verification of crates
  • the order and list of crates to publish is manually maintained, leading to error. cargo 1.84 is more strict and the list is currently wrong

Solution

  • duplicate all the licenses to all crates and remove the --allow-dirty flag
  • instead of a manual list of crates, get it from cargo package --workspace
  • remove the --no-verify flag to... verify more things?

@mockersf mockersf requested a review from cart February 7, 2025 18:05
@alice-i-cecile
Copy link
Member

Prompted by rust-lang/cargo#15151

@mockersf
Copy link
Member Author

mockersf commented Feb 7, 2025

Prompted by rust-lang/cargo#15151

no, that one has just been itching me for a while... it's #17727 that's related to that cargo issue

@mockersf mockersf added this to the 0.16 milestone Feb 9, 2025
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Build-System Related to build systems or continuous integration A-Meta About the project itself S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 9, 2025
alice-i-cecile
alice-i-cecile approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I low-key hate the duplication of licenses here, but I agree that it's the least bad option.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 9, 2025
Merged via the queue into bevyengine:main with commit 7400e7a Feb 9, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Meta About the project itself C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @cart