Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds choose fallback to eg. setup-system etc.. #240

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

molleweide
Copy link
Collaborator

@molleweide molleweide commented Aug 11, 2024

wip. im testing a lot of dorothy commands and adding a choose menu fallback if it makes sense.

@balupton
Copy link
Member

balupton commented Aug 11, 2024

Keep in mind most commands in early dorothy (going back to 2020, etc) did prompt for which action, however it impacted performance. Performance of such a case may not be an issue with the new choose command, however for commands that are likely called a lot, or rather all those called programmatically, then we should not invoke choose, as we want the programmer to provide the optimal arguments.

@molleweide
Copy link
Collaborator Author

makes sense. i should refrain from pushing up PRs to quickly going forward.

@balupton
Copy link
Member

Setup-system would be one worth having it though, as it is user facing rather than programmer facing. setup-until however would be one that shouldn't have it.

@molleweide
Copy link
Collaborator Author

molleweide commented Aug 11, 2024

i see also what you mean also bc the choosecommand is really snappy when it is running but booting up the UI seems to take like 2-3 secs which can be annoying for small commands..

BUT when setup-system is asking for which casks one whishes to install it fires up immediately it seems which is pretty
damn cool

@balupton balupton marked this pull request as draft October 17, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants