Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse_source_type_name #4

Merged
merged 20 commits into from
Dec 4, 2024
Merged

Fix parse_source_type_name #4

merged 20 commits into from
Dec 4, 2024

Conversation

AdrienVannson
Copy link
Contributor

Summary

Fix danielgtaylor/python-betterproto#562 , danielgtaylor/python-betterproto#437

The function parse_source_type_name used to rely on an ad-hoc regex to work. The function failed when the package name had capital letters, since it believed that the package was actually a message.

Now, the function goes through the packages and the messages that are actually defined (no more guess) to find the right one.

I also did some small refactoring of models.py: FieldCompiler used to inherit from MessageCompiler, which made no sense.

The PR still lacks tests and some doc, but since it can take a while to write, I first wanted to have your point of view on this.

NOTE: I completely deleted test_gen_ref_type.py for now, but I plan to replace it once you agree with the content of the PR

Checklist

  • If code changes were made then they have been tested.
  • This PR fixes an issue.

@AdrienVannson AdrienVannson merged commit e45f36a into main Dec 4, 2024
18 checks passed
@AdrienVannson AdrienVannson deleted the models-refactoring-2 branch December 4, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid code generated when package name contains uppercase letter
1 participant