Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Upgrade day #9

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Upgrade day #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bm-tslint-rules",
"version": "0.0.7",
"version": "0.0.8",
"description": "default tslint rules to use for projects using typescript",
"main": "tslint.json",
"files": [
Expand Down Expand Up @@ -28,11 +28,11 @@
"devDependencies": {
"@types/node": "^8.0.30",
"ts-node": "^3.3.0",
"tslint": "5.7.0",
"tslint": "5.8.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check what changed between versions?

Copy link
Contributor Author

@saurabh2590 saurabh2590 Oct 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I did check. Primarily:

  • new features/rules are added which we can discuss if we want to enable them if they are not enabled by default. Maybe separate PR and topic for discussion.
  • Some rules were fixed for the bugs and some were enhanced. Was not possible to gauge the impact on our code via quick glance over the list. And while running tslint with the new version, I just made sure that it doesn't throw up any new warnings or errors.
  • While writing the comment, I cross-checked if there was any update on the rule mentioned in strict-boolean-expressions wrongly reports on short-circuit expressions #4 , but seems no update.
  • Certain options were deprecated on CLI which they plan to remove in further releases.

"tsutils": "^2.8.2",
"typescript": "~2.5.2"
"typescript": "~2.5.3"
},
"peerDependencies": {
"tslint": "5.7.0"
"tslint": "5.8.0"
}
}