fix(ETL): Les départements et régions vides sont mal gérés #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qloridant
had a problem deploying
to
review-apps
GitHub Actions
Failure
raphodn
reviewed
Jan 17, 2025
| @@ -2,7 +2,8 @@ | |||
|
|
|||
|
|
|||
| def get_lib_department_from_code(department: str) -> str: | |||
There was a problem hiding this comment.
Suggested change
| def get_lib_department_from_code(department: str) -> str: | |
| def get_lib_department_from_code(department: str) -> str | None: |
du coup ?
ou rajouter un return par défaut genre return "" si on veut que ca soit un str ?
There was a problem hiding this comment.
J'ai pris la première option !
raphodn
approved these changes
Jan 24, 2025
qloridant
deleted the
4933-fixetl-les-départements-et-régions-vides-sont-mal-gérés
branch
qloridant
had a problem deploying
to
review-apps
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.