Merge pull request #3477 from betagouv/clean_code_naf

Clean code_naf with point in match_filter

app/models/match_filter.rb

@@ -49,12 +49,12 @@ def raw_accepted_legal_forms
   end
 
   def raw_accepted_naf_codes=(naf_codes)
-    updated_naf_codes = naf_codes.split(/[,\s]/).delete_if(&:empty?)
+    updated_naf_codes = naf_codes.delete('.').split(/[,\s]/).delete_if(&:empty?)
     self.accepted_naf_codes = updated_naf_codes
   end
 
   def raw_excluded_naf_codes=(naf_codes)
-    updated_naf_codes = naf_codes.split(/[,\s]/).delete_if(&:empty?)
+    updated_naf_codes = naf_codes.delete('.').split(/[,\s]/).delete_if(&:empty?)
     self.excluded_naf_codes = updated_naf_codes
   end
 

spec/models/match_filter_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe MatchFilter do
+  describe 'getter' do
+    subject { match_filter.raw_accepted_naf_codes }
+
+    let(:match_filter) { create :match_filter, accepted_naf_codes: accepted_naf_codes }
+
+    context 'with full accepted_naf_codes' do
+      let(:accepted_naf_codes) { ["9001Z", "9002Z"] }
+
+      it { is_expected.to eq "9001Z 9002Z" }
+    end
+
+    context 'with empty accepted_naf_codes' do
+      let(:accepted_naf_codes) { [] }
+
+      it { is_expected.to eq '' }
+    end
+  end
+
+  describe 'setter' do
+    subject { match_filter.accepted_naf_codes }
+
+    let(:match_filter) { create :match_filter, raw_accepted_naf_codes: raw_accepted_naf_codes }
+
+    context 'with empty data' do
+      let(:raw_accepted_naf_codes) { '' }
+
+      it { is_expected.to eq [] }
+    end
+
+    context 'with proper values' do
+      let(:raw_accepted_naf_codes) { '90.01Z 9002Z' }
+
+      it { is_expected.to eq ["9001Z", "9002Z"] }
+    end
+
+  end
+end