Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mise à jour des dépendances de Mongo #4740

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Mise à jour des dépendances de Mongo #4740

merged 8 commits into from
Jan 30, 2025

Conversation

jenovateurs
Copy link
Contributor

@github-actions github-actions bot added this to the BC actuel milestone Nov 19, 2024
@jenovateurs jenovateurs marked this pull request as ready for review January 10, 2025 17:10
@jenovateurs
Copy link
Contributor Author

jenovateurs commented Jan 10, 2025 •
edited
Loading

Le dernier check non-valide correspond à CodeQL (système d'IA de review) qui suggère d'ajouter un rate limit de partout.
Qu'en penses-tu @Shamzic ? Sur le principe je suis d'accord mais je propose de le faire avec un nouveau ticket.
Si tu es de mon avis, je retirerai les alertes associées.

@Shamzic
Copy link
Contributor

Shamzic commented Jan 13, 2025

Oui, c'est ok, tu peux les retirer sur Github en cochant la case pour dire que c'est des faux positifs

@jenovateurs jenovateurs requested a review from Shamzic January 28, 2025 15:25
Shamzic
Shamzic requested changes Jan 29, 2025
View reviewed changes
tests/unit/backend/survey.spec.ts Show resolved Hide resolved
tests/unit/backend/survey.spec.ts Outdated Show resolved Hide resolved
tests/unit/backend/survey.spec.ts Outdated Show resolved Hide resolved
tests/unit/backend/survey.spec.ts Outdated Show resolved Hide resolved
tests/unit/backend/survey.spec.ts Outdated Show resolved Hide resolved
@jenovateurs jenovateurs requested a review from Shamzic January 29, 2025 14:29
Shamzic
Shamzic requested changes Jan 29, 2025
View reviewed changes
tests/unit/backend/survey.spec.ts Outdated Show resolved Hide resolved
tests/unit/backend/survey.spec.ts Show resolved Hide resolved
@jenovateurs jenovateurs requested a review from Shamzic January 30, 2025 15:13
Shamzic
Shamzic approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Shamzic Shamzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jenovateurs jenovateurs merged commit 574504d into main Jan 30, 2025
28 checks passed
@jenovateurs jenovateurs deleted the maj-mongo branch January 30, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shamzic Shamzic Shamzic approved these changes

@yasmine-glitch yasmine-glitch Awaiting requested review from yasmine-glitch

Assignees

@jenovateurs jenovateurs

Labels
None yet
Projects
None yet
Milestone
BC actuel
Development

Successfully merging this pull request may close these issues.
2 participants
@jenovateurs @Shamzic