Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create config.h for RC405 #674

Closed
wants to merge 1 commit into from

Conversation

LuckyEmperor
Copy link

New board added, assembled firmware version with this config.h file tested on quadrocopter in flight

New board added, assembled firmware version with this config.h file tested on quadrocopter in flight
@LuckyEmperor
Copy link
Author

Schematics and configuration files have been emailed to [email protected].

Please review.

Thank you for your time and assistance!

@ot0tot
Copy link
Contributor

ot0tot commented Jan 22, 2025

Please see the Betaflight Manufacturer Design Guidelines and update your design appropriately.
https://betaflight.com/docs/development/manufacturer/manufacturer-design-guidelines

@sugaarK Can you create a channel on the discord with the schematics?

#define FC_TARGET_MCU STM32F405

#define BOARD_NAME RC405
#define MANUFACTURER_ID RADIOCOMP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mfg ID should be 4 characters and needs to be added to https://github.com/betaflight/config/blob/master/Manufacturers.md

* I2C Bus *
**********************************************************************/
#define USE_I2C
#define USE_I2C_DEVICE_1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in platform.h

Suggested change
#define USE_I2C_DEVICE_1

Comment on lines +104 to +105
#define BARO_I2C_INSTANCE (I2CDEV_1)
#define MAG_I2C_INSTANCE (I2CDEV_1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define BARO_I2C_INSTANCE (I2CDEV_1)
#define MAG_I2C_INSTANCE (I2CDEV_1)
#define BARO_I2C_INSTANCE I2CDEV_1
#define MAG_I2C_INSTANCE I2CDEV_1

Comment on lines +110 to +111
#define LED0_PIN PC15
#define LED1_PIN PC14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +168 to +172
#define PINIO1_CONFIG 1
#define PINIO2_CONFIG 1
#define PINIO3_CONFIG 1
#define PINIO4_CONFIG 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default

Suggested change
#define PINIO1_CONFIG 1
#define PINIO2_CONFIG 1
#define PINIO3_CONFIG 1
#define PINIO4_CONFIG 1

#define DEFAULT_CURRENT_METER_SCALE 250

#define GYRO_1_ALIGN CW0_DEG
#define GYRO_1_ALIGN_YAW 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use custom alignment when GYRO_1_ALIGN CUSTOM is used.

Suggested change
#define GYRO_1_ALIGN_YAW 0

#define GYRO_1_ALIGN_YAW 0

#define MAG_ALIGN CW0_DEG
#define MAG_ALIGN_YAW 0
Copy link
Member

@haslinghuis haslinghuis Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use custom alignment when MAG_ALIGN CUSTOM is used.

Suggested change
#define MAG_ALIGN_YAW 0

@ot0tot ot0tot closed this Jan 23, 2025
@sugaarK
Copy link
Member

sugaarK commented Jan 25, 2025

any questions about this been closed refer to this...

https://www.opensanctions.org/entities/NK-bNYVWWVXjmujDypSK5YVDi/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants