Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom alignment #648

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix custom alignment #648

merged 1 commit into from
Dec 20, 2024

Conversation

haslinghuis
Copy link
Member

See comment #645 (comment)

@ledvinap
Copy link
Contributor

Why? Valid value is -3600..3600.

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 20, 2024 •
edited
Loading

@ledvinap

  • IMHO if signed it should be -1800..1800 and why use decidegrees. Only clockwise may be easier but just a preference.
  • Should I change to -450 instead ?
  • Saw SPRACINGH7EXTREME using clockwise value

config/configs/SPRACINGH7EXTREME/config.h

Line 250 in f2067f5

#define GYRO_2_ALIGN_YAW 2250

@ledvinap
Copy link
Contributor

I'd keep current state for now, but this PR won't hurt ...

ledvinap
ledvinap approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ledvinap ledvinap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decide yourself ..

@haslinghuis haslinghuis merged commit 3c54148 into betaflight:master Dec 20, 2024
1 check passed
@haslinghuis haslinghuis deleted the fix-alignment branch December 20, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledvinap ledvinap ledvinap approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haslinghuis @ledvinap @nerdCopter