Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table for motor stop and airmode combination #518

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

haslinghuis
Copy link
Member

This pull request includes a small change to the docs/wiki/configurator/motors-tab.md file. The change adds a new table to clarify the behavior of motors when armed under different configurations of AIRMODE and Motor Stop settings.

Changes to docs/wiki/configurator/motors-tab.md:

  • Added a table describing motor behavior when armed under different configurations of AIRMODE and Motor Stop settings.

@haslinghuis haslinghuis self-assigned this Feb 2, 2025
Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for origin-betaflight-com ready!

Name Link
🔨 Latest commit 01b693c
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-com/deploys/679f9fbb15936200081f4e4c
😎 Deploy Preview https://deploy-preview-518.dev.web.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarqubecloud bot commented Feb 2, 2025

@haslinghuis haslinghuis merged commit 0a496c6 into betaflight:master Feb 3, 2025
10 checks passed
@haslinghuis haslinghuis deleted the motor-stop branch February 3, 2025 16:31
@@ -43,6 +43,12 @@ BLHeli_S, BLHeli_32, BlueJay or AM32 ESCs should all use DShot
- **MOTOR_STOP** - Prevent motors spinning at idle when armed. Not normally required and it is considered safer to spin
motors so bystanders can see that your quad is armed

| **Scenario** | **Motors Behavior When Armed** |
|--------------------------------------|----------------------------------------------------|
| **AIRMODE Disabled & Motor Stop Enabled** | Motors stay **off** until throttle is raised. |
Copy link

@dmak dmak Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the text needs some rewording (sorry, the idea came just now):

"Motor Stop" → "MOTOR_STOP"

Let me brush it up a bit:

| **Scenario**                                     | **Motors' behavior when armed**                           |
|--------------------------------------------------|-----------------------------------------------------------|
| `AIRMODE` is disabled & `MOTOR_STOP` is enabled  | Motors **stay off** until throttle is raised.             |
| `AIRMODE` is disabled & `MOTOR_STOP` is disabled | Motors **spin at idle speed** when armed.                 |
| `AIRMODE` is enabled                             | Motors **always spin** when armed, even at zero throttle. |

⚠️ The table needs validation ⚠️

But in combination with PR #4326 it probably does not make much sense, as if AIRMODE is enabled then MOTOR_STOP is hidden. Probably more relevant for older versions of BF?

Copy link
Member

@nerdCopter nerdCopter Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this hobby pilots eventually learn when and what happens. This scenario is akin to when motor-pwm-frequency was still shown, but only applicable if analog protocols were in use. Eventually newcomers want clarification and UI changes so it becomes as such; however, the underlying settings can still exist in CLI.

You are welcome to make a PR to clarify variable names and bold-faces if you feel it necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The relation between MOTOR_STOP and AIRMODE should be better documented
4 participants