Improve configuration for MSP GNSS #4344
Conversation
haslinghuis
commented
Feb 14, 2025
•
haslinghuis
commented
- resolves Enabling GPS with MSP protocol is confusing #3572
- enable gps tab if included in build options
- moves gps feature to gps tab
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/js/utils/updateTabList.js
Outdated
| @@ -12,7 +12,7 @@ export function updateTabList(features) { | |||
| isExpertModeEnabled && FC.CONFIG?.buildOptions?.includes("USE_SERVOS"), | |||
| ); | |||
|
|
|||
| $("#tabs ul.mode-connected li.tab_gps").toggle(features.isEnabled("GPS")); | |||
| $("#tabs ul.mode-connected li.tab_gps").toggle(isExpertModeEnabled && FC.CONFIG?.buildOptions?.includes("USE_GPS")); | |||
There was a problem hiding this comment.
GPS is not showing (Configuration-Tab) on virtualFC in this PR. It does show in master.
There was a problem hiding this comment.
is this indeed for the configuration tab toggle? if so, would rather not require expert-mode -- will confuse pilots.
There was a problem hiding this comment.
- Does show here (the first time):
- Now switching expert mode on off on it removes even more tabs.
There was a problem hiding this comment.
i dont know why but ad449a6d is still as above sreenshot.
There was a problem hiding this comment.
Did you mean to remove DISPLAY ?
There was a problem hiding this comment.
no, i mean GPS does not exist here. GPS hidden.
There was a problem hiding this comment.
Yes correct - the GPS feature has been moved to GPS tab now to be able to configure MSP GPS without having to activate GPS sensor in ports tab (stills needs to enable MSP on the UART used off course).
There was a problem hiding this comment.
oh, okay. i did not follow that idea. interesting.
What if it remains in both locations, since "features" were always in configuration tab?
This should be discussed by all devs, i feel.
There was a problem hiding this comment.
Already did the same for receiver, motor and pid tuning tab
This comment was marked as outdated.
This comment was marked as outdated.
|
@nerdCopter no idea why the tooltip does not work - so added it manual |
haslinghuis
requested review from
limonspb,
blckmn,
ctzsnooze and
VitroidFPV
|
Thanks for these improvements! I don't have an MSP GPS to test, but seems to have no problems with my setup with a serial GPS. One small thing... if there is no serial port assigned to GPS, the 'enable GPS' switch at the top is greyed out. That's great! The tooltip then says, "Configure Port scenario first", and that makes sense as well. However, I am able to move the switch to 'on', even though there is no serial port available. If I save that change, and come back to the GPS tab, it remains off. I don't know if it's feasible prevent the switch from moving into the 'on' position when there is no GPS Serial or MSP port available. That would be a tiny bit nicer. But I wouldn't worry about it too much, the user will eventually check the tooltip. One other thing about the tooltip: even if the port is correctly configured for GPS in the ports tab, the tooltip says the same "Configure Port scenario first" message. Perhaps it should say "Enable/Disable GPS data. If GPS cannot be enabled, check that a Port is assigned to GPS in the Ports Tab" or something like that? Not sure how best to do this. Already this is a big improvement. |
|
