Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual info about pdop quality #4343

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Add visual info about pdop quality #4343

merged 1 commit into from
Feb 13, 2025

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Feb 12, 2025 •
edited
Loading

image

pdop status color stars
0 - 1 ideal blue ★★★★★
1 - 2 excellent green ★★★★☆
2 - 5 good orange ★★★☆☆
5 - 10 moderate yellow ★★☆☆☆
10 - 20 fair red ★☆☆☆☆
20 - 100 poor gray ☆☆☆☆☆

image

@haslinghuis haslinghuis added this to the 11.0 milestone Feb 12, 2025
@haslinghuis haslinghuis self-assigned this Feb 12, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 627a4e8
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/67ad2936415ec400084ad8c8
😎 Deploy Preview https://deploy-preview-4343.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis force-pushed the dop branch 3 times, most recently from c01b42c to b7f8d11 Compare February 12, 2025 21:37
@Pancronos
Copy link

Wonderful work. Much appreciated

@haslinghuis
Add visual info about pdop quality
627a4e8 
fix display of magnetic declination

swapped moderate and fair :)

remove not needed href for latlon

revert remove not needed href for latlon
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ctzsnooze
ctzsnooze approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@ctzsnooze ctzsnooze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on conceptual idea, which I like a lot. Not tested.

@haslinghuis haslinghuis merged commit 2d0f682 into betaflight:master Feb 13, 2025
9 checks passed
@haslinghuis haslinghuis deleted the dop branch February 13, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonspb limonspb limonspb approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@blckmn blckmn Awaiting requested review from blckmn

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@VitroidFPV VitroidFPV Awaiting requested review from VitroidFPV

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

DOP Easy interpretation
5 participants
@haslinghuis @Pancronos @limonspb @ctzsnooze @nerdCopter