Add magnetic declination info #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nerdCopter
approved these changes
Feb 7, 2025
|
VitroidFPV
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on enhancing the GPS tab functionality and improving the user interface for magnetic declination settings. The key changes include the addition of magnetic declination data handling, refactoring the GPS data update logic, and updating the localization messages.
Enhancements to GPS tab functionality:
src/js/tabs/gps.js: Refactored thegps.initializefunction to include magnetic declination data handling. This involves checking for the presence of a magnetometer sensor and updating the UI accordingly. [1] [2] [3] [4] [5]User interface improvements:
src/tabs/gps.html: Added a new row in the GPS information table to display magnetic declination data.Localization updates:
locales/en/messages.json: Changed the term "Magnetometer Declination" to "Magnetic Declination" for better clarity.