Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/multi modal support #427

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Feat/multi modal support #427

merged 8 commits into from
Feb 4, 2025

Conversation

kartik4949
Copy link
Contributor

This is an attempt to support basic multimodal inputs for openai
#413 #412

@kartik4949 kartik4949 force-pushed the feat/multi-modal-support branch from 5cb9db5 to a7e1237 Compare January 31, 2025 08:30
@kartik4949 kartik4949 added this to the v0.2.0 milestone Feb 3, 2025
@kartik4949 kartik4949 force-pushed the feat/multi-modal-support branch from a7e1237 to e1d48e8 Compare February 3, 2025 13:39
vutrung96
vutrung96 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@vutrung96 vutrung96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. let's try this out on large datasets / pipelines.

@kartik4949 kartik4949 force-pushed the feat/multi-modal-support branch from f776c33 to e0dbf92 Compare February 4, 2025 12:27
madiator
madiator reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@madiator madiator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Added some comments.

examples/multimodal/recipe.py Outdated Show resolved Hide resolved
examples/multimodal/recipe.py Outdated Show resolved Hide resolved
src/bespokelabs/curator/request_processor/openai_request_mixin.py Outdated Show resolved Hide resolved
src/bespokelabs/curator/request_processor/openai_request_mixin.py Outdated Show resolved Hide resolved
src/bespokelabs/curator/request_processor/openai_request_mixin.py Outdated Show resolved Hide resolved
src/bespokelabs/curator/types/prompt.py Outdated Show resolved Hide resolved
src/bespokelabs/curator/types/prompt.py Outdated Show resolved Hide resolved
@kartik4949 kartik4949 merged commit ea1e69d into bespokelabsai:main Feb 4, 2025
1 check passed
@kartik4949 kartik4949 deleted the feat/multi-modal-support branch February 4, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madiator madiator madiator approved these changes

@vutrung96 vutrung96 vutrung96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kartik4949 @madiator @vutrung96