Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json marshaler interface to log's entry interface #58

Closed
wants to merge 1 commit into from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Mar 21, 2022

No description provided.

@gfanton gfanton self-assigned this Mar 21, 2022
@gfanton gfanton requested a review from a team as a code owner March 21, 2022 14:13
@auto-add-label auto-add-label bot added the enhancement New feature or request label Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eb69a86) 68.87% compared to head (1efd55a) 68.80%.
Report is 1 commits behind head on master.

Files Patch % Lines
entry/entry.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   68.87%   68.80%   -0.08%     
==========================================
  Files          23       23              
  Lines        1825     1827       +2     
==========================================
  Hits         1257     1257              
- Misses        365      367       +2     
  Partials      203      203              
Flag Coverage Δ
unittests 68.80% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefft0 jefft0 removed 🔍 Ready for Review enhancement New feature or request labels Apr 18, 2023
@jefft0 jefft0 removed the request for review from a team April 19, 2023 08:38
@jefft0
Copy link
Collaborator

jefft0 commented Nov 24, 2023

@gfanton , these changes seem harmless, but are they being used anywhere?

@jefft0 jefft0 added more info needed Waiting for a response and removed more info needed Waiting for a response labels Nov 24, 2023
@jefft0
Copy link
Collaborator

jefft0 commented Nov 24, 2023

@jefft0 to do a local replace and see if we can still compile dependant repos like weshnet and berty. Check if the changes in this PR force those repos to implement json marshalling.

@jefft0 jefft0 force-pushed the feat/add-entry-json-marshaler branch from 66d5c71 to 1efd55a Compare November 29, 2023 11:37
@jefft0
Copy link
Collaborator

jefft0 commented Nov 29, 2023

I did a force push of of rebasing this PR to the latest master.

@jefft0
Copy link
Collaborator

jefft0 commented Nov 29, 2023

This repo is a dependency for go-orbit-db. I update its go.mod with a replace to use this PR. make test on go-orbit-db has a stack overflow error. See the attached log.
error.txt

@gfanton said "Looks like a recursive json unmarshal. Will be hard to find".

@jefft0
Copy link
Collaborator

jefft0 commented Nov 29, 2023

I confirm that we can build go-orbit-db, weshnet and berty with a local go.mod replace for this PR. But still have the "stack overflow" error shown above.

@jefft0
Copy link
Collaborator

jefft0 commented Dec 1, 2023

@gfanton will ask if it's OK to merge this.

@jefft0 jefft0 added the more info needed Waiting for a response label Dec 1, 2023
@jefft0
Copy link
Collaborator

jefft0 commented Jan 12, 2024

Closing. @gfanton says "doesn't think it will be useful anyways and can probably introduce some problems."

@jefft0 jefft0 closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info needed Waiting for a response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants