Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: In example, run go mod tidy. Fix the test compile error and expected Output #103

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

jefft0
Copy link
Collaborator

@jefft0 jefft0 commented Nov 29, 2023

This PR fixes the test in the examples folder because of changes in the latest kubo dependencies. After these changes, the test passes.

  • In examples, run go mod tidy
  • In example_log_append_test.go, fix a compile error by changing cfg.False to config.False
  • The latest kubo annoyingly prints messages to the console like "go-libp2p resource manager protection disabled", so update the test expected Output.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb69a86) 68.87% compared to head (b1b5af4) 68.87%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files          23       23           
  Lines        1825     1825           
=======================================
  Hits         1257     1257           
  Misses        365      365           
  Partials      203      203           
Flag Coverage Δ
unittests 68.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit 5a60ef8 into berty:master Dec 1, 2023
8 checks passed
@jefft0 jefft0 deleted the fix/example-test branch December 1, 2023 15:21
Copy link

github-actions bot commented Dec 1, 2023

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants