Refactor constructField

bernhardmgruber · Jan 21, 2024 · cb2b150 · cb2b150
1 parent c7d9806
commit cb2b150
Showing 1 changed file with 12 additions and 17 deletions.
diff --git a/include/llama/View.hpp b/include/llama/View.hpp
@@ -98,34 +98,29 @@ namespace llama
         typename Mapping::ArrayExtents::Index ai,
         RecordCoord<RCs...> rc)
     {
-        using FieldType = GetType<typename Mapping::RecordDim, decltype(rc)>;
-
-        // this handles physical and computed mappings
-        if constexpr(sizeof...(RCs) == 0)
+        auto init = [](auto&& ref) LLAMA_LAMBDA_INLINE
         {
-            using RefType = decltype(view(ai));
+            using FieldType = GetType<typename Mapping::RecordDim, RecordCoord<RCs...>>;
+            using RefType = decltype(ref);
             if constexpr(isProxyReference<RefType>)
             {
-                view(ai) = FieldType{};
+                ref = FieldType{};
             }
             else if constexpr(
                 std::is_lvalue_reference_v<RefType> && !std::is_const_v<std::remove_reference_t<RefType>>)
             {
-                new(&view(ai)) FieldType{};
+                new(&ref) FieldType{};
             }
+        };
+
+        // this handles physical and computed mappings
+        if constexpr(sizeof...(RCs) == 0)
+        {
+            init(view(ai));
         }
         else
         {
-            using RefType = decltype(view(ai)(rc));
-            if constexpr(isProxyReference<RefType>)
-            {
-                view(ai)(rc) = FieldType{};
-            }
-            else if constexpr(
-                std::is_lvalue_reference_v<RefType> && !std::is_const_v<std::remove_reference_t<RefType>>)
-            {
-                new(&view(ai)(rc)) FieldType{};
-            }
+            init(view(ai)(rc));
         }
     }