-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added show_object as a Method Alias for show #8
Conversation
Hi @jmwright Or do I miss something? |
btw. - and you might have seen this - jupyter_cadquery already runs on binder ... |
No, I was missing something. That makes more sense than altering the jupyter-cadquery codebase. Thanks.
Yeah, I've played with it a little bit on MyBinder. Is there a way I can have that open the tutorials? If so, I'm happy to do it that way. I'm not terribly familiar with the way all of the Jupyter infrastructure works. Here are the tutorials: https://github.com/jmwright/cadquery-contrib/tree/master/tutorials |
I admit, I also had a hard time to understand everything ;-) I guess, what we would need to achieve is independence, i.e. whenever you change something it is reflected on binder without me building a new version of jupyter-cadquery. One easy way seems to be:
I am happy to add a notebook "install cadquery tutorials.ipynb" with this git command to my example folder, so that a new user just has to open this notebook in binder, press <shift-enter>, and get your folder hierarchy in the navigation bar? |
If we do it like this, it would be great if the python files under examples would actually also be notebooks. Then one could use them the same way on binder like all the other examples, tutorials, ... |
Could we point to the upstream repo instead? I've merged my first two tutorials into it: https://github.com/CadQuery/cadquery-contrib
So the example files would have both a |
And btw., if you would prefer complete independence of our two projects, instead of me adding a "install contrib" notebook you could have a section in your readme with an explanation
|
Side note: 3D_Printer_Extrusion_Support.py copied into a notebook throws an exception for me
|
I'd like to leverage your great work as much as possible. My end goal was to try to enable users to get to the tutorials by simply clicking a link in the cadquery readme. Most CadQuery users are used to development workflows though, and so executing the git clone step shouldn't be a problem for them. If you would create a Is there some way to make the raw .py examples and the .ipynb files work seamlessly together with something like the
That example throws the same error in CQ-editor as well. It must have gotten broken during the transition to PythonOCC and was never noticed because it was in the contrib repo. I've created an issue for it: CadQuery/cadquery-contrib#3
We don't advertise the contrib repo much, but it's a place where the community can contribute things like examples, tutorials and helpful scripts. I think the end goal would be for the broader community to be the maintainers of it, but for the time being it's just the core devs. We welcome contributions of course though. |
@bernhard-42 I'm going to go ahead and close this PR since it's no longer relevant (but was useful for sparking a good discussion). |
@jmwright I have created a notebook https://github.com/bernhard-42/jupyter-cadquery/blob/master/examples/install-cadquery-contrib.ipynb which allows to clone Does this help? |
Yes it does, thank you. I was able to remove a couple of clunky bullet points from the instructions. I've updated the cadquery-contrib/tutorials readme to reflect the changes. |
great. |
That's great. Out of curiosity I tried the tutorial on an Android tablet (Chrome browser). The viewer loaded fine, but the model never displayed. I don't have access to the developer tools or I would dig deeper. |
@bernhard-42 I'm not sure if you'll want to accept this, but I'm working on creating a set of CadQuery tutorials using this extension and MyBinder.org, and I would like to avoid changing the current standard syntax (
show_object
) as much as possible in the examples.If you don't want the clutter I understand. I can run the tutorials on my fork.