Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Python files and update dictionary #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

silvncr
Copy link

@silvncr silvncr commented Oct 16, 2023

I discovered your library and thought I could contribute since I plan to use it. I've done the following:

  • Conventionalised Python files.
  • Updated scrabble/dictionary.json according to the Collins Official Scrabble Dictionary (2019).
  • Added dependency for setuptools since it's used in setup.py.

@silvncr
Copy link
Author

silvncr commented Dec 20, 2023

Upon re-reading my PR, I've realised that adding setuptools as a dependency is pointless; I've removed that now.

@silvncr
Copy link
Author

silvncr commented Dec 20, 2023

I think that's all. Something else I will bring up as an option to you, though, is to use the qrs library's wordlist_full list instead of having to maintain your own copy.

$ pip install qrs
$ py
>>> import qrs
>>> print(qrs.wordlist_full)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant