Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. typing fixes #84

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Misc. typing fixes #84

merged 6 commits into from
Dec 9, 2024

Conversation

benbovy
Copy link
Owner

@benbovy benbovy commented Dec 6, 2024

Many typing issues were not caught by mypy (untyped unit tests).

@benbovy benbovy added this to the 0.1.0 milestone Dec 6, 2024
src/spherely.pyi Outdated Show resolved Hide resolved
src/spherely.pyi Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.15%. Comparing base (38a0693) to head (b07515d).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   94.00%   88.15%   -5.85%     
==========================================
  Files           5       13       +8     
  Lines         200      785     +585     
  Branches        8       61      +53     
==========================================
+ Hits          188      692     +504     
- Misses          5       63      +58     
- Partials        7       30      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I have no error locally.
@benbovy
Copy link
Owner Author

benbovy commented Dec 9, 2024

I have no idea why CI passed in 20a5836 and not in 3ad4104 (both using mypy version <1). Anyway, using mypy 1.x seems to work in the last commit (I've run the workflow multiple times to make sure it is not flaky).

@benbovy benbovy merged commit ad27fbe into main Dec 9, 2024
15 checks passed
@benbovy benbovy deleted the typing-fixes branch December 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants