Fix error on mysql-server-5.7.7-rc #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated jQuery to v1.11.3, Bootstrap to v3.3.4. interface.php has been updated to accommodate the changes in Bootstrap on the home page. Further work is necessary to update the remaining portions of the file. Readme has been updated with a demo site. Remaining files are edited as a result of a minor reformatting in Phpstorm.
|
Just pushed a big commit that starts the process of updating jQuery to v1.11.3, Bootstrap to v3.3.4, and editing (primarily) interface.php to address the new versions. I've also added Bootstrap tooltips to the images next to each field to address #19. |
|
👍 Thanks for taking the time. As soon as I have time, I'll test, verify, and merge. |
added 3 commits
May 18, 2015 12:07
updated license link in all files to HTTPS instead of non-SSL link
-completed formatting interface.php and pw.php for updated Bootstrap -formatted about.php for updated Bootstrap -updated ZeroClipboard to v2.2.0 -updated readme with new test server (same server, just has a domain name now) -converted line endings to LF (some were CRLF previously) -removed Placeholder library as it is not being used -verified all pages with W3C HTML Validator for HTML5
bemosior
added a commit
that referenced
this pull request
May 29, 2015
Merge @vaindil contributions.
|
Thanks again for all the changes! I do need to revisit this project to clean it up, as I'm generally not happy with the design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RC of mysql-server-5.7.7 doesn't like the format of the input time when creating new secrets. Using
DATE_ADD()and a little syntax editing corrects the problem. I've verified this on my live server (mysql-server-5.7.7-rc, Ubuntu Server 14.04) and on a fresh test server (mysql-server-5.5, Ubuntu Server 14.04); the changes work properly on each.The specific error is below, where
300is replaced with the correct number of minutes based on the input.