Makefile: Allow building libquickjs as a shared library #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanodan
force-pushed
the
sharedlib
branch
2 times, most recently
from
5cf8838 to
2118062
Compare
|
FYI: #195 |
|
If the issue is ABI versioning/stability, it shouldn't be a problem here because it doesn't introduces it.
The SONAME includes the version, so on linking with current version the NEEDED entry ends up being `libquickjs.so.2024.01.13`.
|
|
@lanodan np, I personally wouldn't mind having an .so version as well, was just highlighting that it was brought up before in the context of this project. Also, the friendly fork quickjs-ng seems to support it https://github.com/quickjs-ng/quickjs/blob/0de570988a0decf7676ebcc831817fc844746bac/CMakeLists.txt#L86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from https://git.alpinelinux.org/aports/tree/community/quickjs/01-sharedlib.patch?id=27a8f649949c36bfc3e45854e08c48a8eb06e07c
Co-Authored-By: Celeste [email protected]