Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another try for fixing ">" comparison for Octopress #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdillahu
Copy link

Fixing usage with Octopress where ">" comparison doesn't work. Based on info from https://github.com/soonhokong pull request

I'm not a great Ruby person, so this may still have issues, but it seems like its been working for me.

You do have to be careful if you're changing layouts or something to actually touch the index files that are affected.

Fixing usage with Octopress where ">" comparison doesn't work. Based on info from https://github.com/soonhokong pull request
@belkadan
Copy link
Owner

I don't understand why > comparison doesn't just work when Time includes Comparable. I'm not actively focused on my jekyll fork right now, but I haven't even looked at the error on 1.9.2, and I'm guessing that this is not the problem.

@bdillahu
Copy link
Author

I'm afraid answering the "why > doesn't work" is beyond me at the moment. I understand the issue that this probably isn't the best fix, but wanted to offer it up in case it was some help.

Thanks for all your work on this fork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants