Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed self reference loop #413

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fixed self reference loop #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca51458
Fixed self reference loop
TheBurchLog Oct 30, 2023
4cea5e5
Update CHANGELOG.rst
TheBurchLog Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Brewtils Changelog
TBD

- Expanded Auto Generation to support Literal Type Hinting, if python version >= 3.8
- Fixed self reference bug in SystemClient

3.19.0
------
Expand Down
3 changes: 1 addition & 2 deletions brewtils/rest/system_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ def __init__(self, *args, **kwargs):
self._loaded = False
self._system = None
self._commands = {}
self._current_system_namespace = -1

# Need this for back-compatibility (see #836)
if len(args) > 2:
Expand Down Expand Up @@ -257,8 +258,6 @@ def __init__(self, *args, **kwargs):
elif len(self._system_namespaces) == 1:
self._system_namespace = self._system_namespaces[0]
self._current_system_namespace = -1
else:
self._current_system_namespace = -1

self._always_update = kwargs.get("always_update", False)
self._timeout = kwargs.get("timeout", None)
Expand Down
Loading