Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-safe with empty branch name #5

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Conversation

omus
Copy link
Member

@omus omus commented Jan 20, 2025

Branch name on main is resolving to false: https://github.com/beacon-biosignals/docker-build/actions/runs/12876123486/job/35898954790#step:5:262. This change should at least result in not writing out cache-branch-false. Not sure why we aren't picking up main yet.

@omus
Copy link
Member Author

omus commented Jan 20, 2025

I've ran into an issue. The push event doesn't have a base image to pull from for the initial build on a PR so we always see a failure with the first PR commit for the push event when building off of the cache. There's also an issue on main where it seems the branch is not being picked up properly

@omus
Copy link
Member Author

omus commented Jan 21, 2025

Ah, part of the problem is using separate image repositories. We aren't really testing a build from a cache for the first commit on a PR as the base SHA being referenced is built in whalesay-push and not whalesay-pr.

@omus
Copy link
Member Author

omus commented Jan 21, 2025

As it turns out the only way to truly test this is to merge this into main and make another PR to validate it's working I'll go ahead and just do that

@omus omus marked this pull request as ready for review January 21, 2025 15:10
@omus omus merged commit f505e2a into main Jan 21, 2025
10 checks passed
@omus omus deleted the cv/fallback-to-empty-branch-name branch January 21, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant