[SW-164] Add ruff and black formatting to spot_wrapper

[khughes-bdai]

Change Overview

This PR enforces ruff and black linting for all files in spot_wrapper. Pre-commit hooks have been added, and all existing code that did not meet these style requirements has been modified to do so. The configuration files added were taken from the spot_ros2 repository.

Testing Done

I tested a few general Spot examples (move the arm, walk forward) that rely on spot_wrapper and the functionality was unchanged.

[khughes-bdai]

Current dependencies on/for this PR:

• main
  • PR [SW-164] Add ruff and black formatting to spot_wrapper #84 👈

This stack of pull requests is managed by Graphite.

[khughes-bdai]

TODO this is still failing black tests on the runner for wrapper_helpers.py

[heuristicus]

Is there a need to use a line length of 120 characters rather than the default of 88? Details at https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length.

[khughes-bdai]

Is there a need to use a line length of 120 characters rather than the default of 88? Details at https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length.

The 120 character line length is also used in spot_ros2 as well as some of our internal repositories, which was where I got that number from. If it's updated here, would we also want to update those other repos?

[bhung-bdai]

@khughes-bdai internally we follow googles style guide mostly. I think we should go with the default/previously enforced limit in the public facing spot_wrapper. Was there a specific standard previously @heuristicus ?

[heuristicus]

I thought it might be related to internal BDAI policy, and I have no objection if you want to use 120 length to conform to that. I was previously using black on this repository and on spot_ros with default settings. The code itself didn't follow any style guide, although function comments do use the google style.

[bhung-bdai]

@heuristicus Introducing these precommits will implicitly enforce the Google style. If you are ok with that, I will ask @khughes-bdai to add a link to the style guide on the README

[heuristicus]

Sure, sounds good.

[bhung-bdai]

Can you add a link to the Google style guide and a quick blurb about it being the default style?